Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time alignment #23

Merged
merged 12 commits into from
Dec 10, 2024
Merged

Time alignment #23

merged 12 commits into from
Dec 10, 2024

Conversation

alessandratrapani
Copy link
Collaborator

@alessandratrapani alessandratrapani commented Dec 7, 2024

To review after merging #22
Everything should be aligned to the miniscope data recording start time.
Sometimes the first timestamps of the miniscope imaging data are negative.
Thus we need to shift back the recording start time, taking the first negative timestamp as time shift.
When shiting back the recording start time, that is the session start time, all the other traces need to shift forward by the same time shift.

run nwbinspector on nwb file generated with this code version:

@alessandratrapani alessandratrapani self-assigned this Dec 7, 2024
@alessandratrapani alessandratrapani mentioned this pull request Dec 9, 2024
2 tasks
@alessandratrapani alessandratrapani changed the base branch from main to add_subject_metadata December 9, 2024 13:28
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in person, takes into account the negative shift of the imaging data and shifts everything to take this into account.

Base automatically changed from add_subject_metadata to main December 10, 2024 09:15
@alessandratrapani alessandratrapani merged commit 120a764 into main Dec 10, 2024
@alessandratrapani alessandratrapani deleted the time_alignment branch December 10, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants