Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pyproject toml instead of setup.py #382

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Use pyproject toml instead of setup.py #382

merged 9 commits into from
Dec 11, 2024

Conversation

h-mayorquin
Copy link
Collaborator

Using the standard file for metadata.

@h-mayorquin h-mayorquin self-assigned this Dec 10, 2024
@h-mayorquin h-mayorquin changed the title Use pyroject toml for setup Use pyroject toml instead of setup.py Dec 10, 2024
@h-mayorquin h-mayorquin changed the title Use pyroject toml instead of setup.py Use pyproject toml instead of setup.py Dec 10, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review December 11, 2024 14:28
pauladkisson
pauladkisson reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks @h-mayorquin!

Could you update the installation page in the documentation?

@h-mayorquin
Copy link
Collaborator Author

h-mayorquin commented Dec 11, 2024 •
edited
Loading

OK, Done.
I also added the changelog and docs on the pyproject.toml so it gets displayed on pipy.

pauladkisson
pauladkisson reviewed Dec 11, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@pauladkisson
Copy link
Member

Nit: Can you put the urls after optional dependencies? I feel like the dependencies and optional dependencies should go together.

@h-mayorquin
Copy link
Collaborator Author

Feel free to re-format this as you prefer actually. I have no strong preference : )

@pauladkisson
Copy link
Member

Feel free to re-format this as you prefer actually. I have no strong preference : )

My perfectionist/OCD tendencies kicking in fs here 😂😅

@h-mayorquin
Copy link
Collaborator Author

Feel free to re-format this as you prefer actually. I have no strong preference : )

My perfectionist/OCD tendencies kicking in fs here 😂😅

If you can make it more comfortable to work with for no cost then that's great!

@h-mayorquin h-mayorquin merged commit bf15323 into main Dec 11, 2024
29 checks passed
@h-mayorquin h-mayorquin deleted the use_pyroject_tomol branch December 11, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauladkisson pauladkisson pauladkisson approved these changes

Assignees

@h-mayorquin h-mayorquin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-mayorquin @pauladkisson