Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings for channel for all extractors #389

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

h-mayorquin
Copy link
Collaborator

Continues on #387.

Addresses #386

@h-mayorquin h-mayorquin marked this pull request as ready for review February 18, 2025 20:04
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is this ready to merge?

@h-mayorquin
Copy link
Collaborator Author

Yes. This should catch the rest.

@h-mayorquin h-mayorquin merged commit 30b37f3 into main Feb 20, 2025
29 checks passed
@h-mayorquin h-mayorquin deleted the remove_channel_instances branch February 20, 2025 23:39
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (7aa2a63) to head (da8a3b4).
Report is 66 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #389       +/-   ##
=========================================
- Coverage   79.37%      0   -79.38%     
=========================================
  Files          39      0       -39     
  Lines        3069      0     -3069     
=========================================
- Hits         2436      0     -2436     
+ Misses        633      0      -633     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 38 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants