Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated tifffile requirements #390

Merged
merged 4 commits into from
Feb 20, 2025
Merged

updated tifffile requirements #390

merged 4 commits into from
Feb 20, 2025

Conversation

pauladkisson
Copy link
Member

Fixes Failing Dailies

@h-mayorquin
Copy link
Collaborator

I would vote against putting a ceiling on tifffile. Reasons:

  1. Writing is not a central part of this library. It is nice to have but not central. Newer versions of tifffile offer new capabilities that I think we should not let it pass (what is a good word for it?).
  2. We can use imwrite instead to accomplish the same goal. The specific function that we are using for writing was deprecated but the general writing functionality was not:

https://github.com/cgohlke/tifffile/blob/f1d053c1f9922a207b84df615eefa52c6fbae3bb/tifffile/tifffile.py#L1309

@pauladkisson
Copy link
Member Author

Fair enough. tifffile v2018.10.18 doesn't have imwrite, but v2018.11.6 and onward does.

@pauladkisson pauladkisson merged commit b731536 into main Feb 20, 2025
29 checks passed
@pauladkisson pauladkisson deleted the tiff branch February 20, 2025 19:40
@h-mayorquin
Copy link
Collaborator

Yeah, I think we should probably drop the writing aspect as we don't use it and it is just one more thing to maintain.

@pauladkisson
Copy link
Member Author

Yeah, I think we should probably drop the writing aspect as we don't use it and it is just one more thing to maintain.

Yes...one of the many things I fixed in my roiextractors 0.6.0 PRs...

@h-mayorquin
Copy link
Collaborator

Oh, great, I did not know it was on the works. Are those PRs only in your system or is it here?

@pauladkisson
Copy link
Member Author

Are those PRs only in your system or is it here?

Not exactly sure what you mean, but you can see I removed write_imaging in #365

@h-mayorquin
Copy link
Collaborator

here means the repo so the answer is yes. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants