#1650 Approval Tests #1654
Closed
#1650 Approval Tests #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Editied approval tests to expect correct behavior.
…ng correctly on my machine.
|
Ok, I see the issue. However, the tests will have to be part of #1651, as merging failing tests that will not be fixed within a known (and short) time-frame would provide too much impedance for further development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I may not have the time shortly to find a good solution for #1651
So this is a separate PR containing only the tests which reveal the erroneous behavior I am trying to fix.
I expect that this will fail CI as this PR is adding a test which is failing against master. However, I believe that it should be merged because the behavior in master is legitimately failing to produce expected results.
GitHub Issues
Shows #1650
Shows #417