Clear cache processing #2962
Merged
Clear cache processing #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claud-io
reviewed
Aug 17, 2023
| $deleted = 0; | ||
| $log = fopen('./cli/clearedLocalResults.log', 'w'); | ||
|
|
||
| $MIN_DAYS = max($days_results_kept, 0.1); |
There was a problem hiding this comment.
why 0.1? also we can just return early if days_results_kept is not set
There was a problem hiding this comment.
0.1 was carried over from archive.php. We don't do any processing if $days_results_kept is not set, we just add a couple log statements. I can return early, but similarly this follows the archive flow.
www/cli/clearCache.php
Outdated
| * @param mixed $logFile | ||
| * @param mixed $match | ||
| */ | ||
| function CheckTest($testPath, $id, $elapsedDays) |
There was a problem hiding this comment.
Suggested change
| function CheckTest($testPath, $id, $elapsedDays) | |
| function DeleteExpiredTest($testPath, $id, $elapsedDays) |
www/cli/clearCache.php
Outdated
| * @param mixed $dir | ||
| * @param mixed $baseID | ||
| */ | ||
| function CheckDay($dir, $baseID, $elapsedDays) |
There was a problem hiding this comment.
Those "checks" are a bit misleading
Suggested change
| function CheckDay($dir, $baseID, $elapsedDays) | |
| function DeleteTestsExpiredOn($dir, $baseID, $elapsedDays) |
claud-io
approved these changes
Aug 17, 2023
pmeenan
approved these changes
Aug 17, 2023
www/cli/clearCache.php
Outdated
| foreach ($days as $day) { | ||
| $dayDir = "$monthDir/$day"; | ||
| if (is_dir($dayDir) && $day != '.' && $day != '..') { | ||
| $elapsedDays = ElapsedDays($year, $month, $day); |
There was a problem hiding this comment.
You can remove the $elapsedDays (and from the passed-into functions). That is the elapsed time based on the test ID but it's not used for this cache cleanup. The actual cleanup is entirely done with "last accessed" time for the test.
www/cli/clearCache.php
Outdated
| /** | ||
| * Calculate how many days have passed since the given day | ||
| */ | ||
| function ElapsedDays($year, $month, $day) |
claud-io
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cached result processing.