Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make status_justify configurable #145

Merged
merged 5 commits into from
Mar 17, 2024
Merged

make status_justify configurable #145

merged 5 commits into from
Mar 17, 2024

Conversation

anopheles
Copy link
Contributor

No description provided.

@anopheles anopheles mentioned this pull request Feb 28, 2024
Closed
@vdbe
Copy link
Contributor

vdbe commented Feb 28, 2024

The default for status-justify is left, would it not be better to just remove the set line for it and let users set it?
You can also just overwrite it.

@anopheles
Copy link
Contributor Author

I would only do that if I were confident that this theme works well with every justify setting. Otherwise an existing tmux config may look broken. Making this setting explicit moves the responsibility to the user. Otherwise, totally agree! 👍

sgoudham
sgoudham requested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for the PR, I think it has merit.

I believe @89iuv would also want you to update the documentation to explicitly mention this option in the README#Status

@sgoudham sgoudham linked an issue Mar 6, 2024 that may be closed by this pull request
How to center pane numbers in status? #144
Closed
@anopheles anopheles requested a review from sgoudham March 12, 2024 15:59
@sgoudham sgoudham requested review from vdbe and removed request for sgoudham March 12, 2024 16:07
vdbe
vdbe suggested changes Mar 12, 2024
View reviewed changes
catppuccin.tmux Show resolved Hide resolved
@anopheles anopheles requested review from sgoudham and vdbe March 15, 2024 16:07
@vdbe vdbe mentioned this pull request Mar 16, 2024
Closed
@sgoudham sgoudham removed their request for review March 17, 2024 15:11
@vdbe vdbe merged commit 843946e into catppuccin:main Mar 17, 2024
3 checks passed
Andreasgdp added a commit to Andreasgdp/tmux-catppuccin that referenced this pull request Mar 19, 2024
@Andreasgdp
Revert "make status_justify configurable (catppuccin#145)"
b1eac63 
This reverts commit 843946e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoudham sgoudham sgoudham approved these changes

@vdbe vdbe vdbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to center pane numbers in status?
3 participants
@anopheles @vdbe @sgoudham