Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pronouns.cc): init #1449

Merged
merged 14 commits into from
Nov 17, 2024
Merged

Conversation

comfysage
Copy link
Contributor

🎉 Theme for pronouns.cc 🎉

preview-image

💬 Additional Comments 💬

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@comfysage comfysage requested a review from a team as a code owner November 14, 2024 11:00
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might consider theming --bs-nav-link-color as subtext0 so theres more of a diffrence with active links.

There's too much contrast here:
{12E81ABE-439D-42C0-85ED-816C158469C9}
This can be found on a users page.

It also strips the borderes
{527E2B09-EC13-4225-9651-B954D9F87CD2}

Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to now have other broken buttons
{7BB6BEEA-D260-45E5-98F0-E56DCCBBF144}
image

isabelroses
isabelroses previously approved these changes Nov 14, 2024
isabelroses
isabelroses previously approved these changes Nov 14, 2024
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The border on this tooltip in the adding pronouns UI appears unthemed:

CleanShot 2024-11-15 at 19 38 17

Border and selected item in this dropdown UI on the edit profile page (Preferences section) are unthemed:

CleanShot 2024-11-15 at 19 39 08

Borders for the cards on https://pronouns.cc/settings/auth unthemed.

Menu toggle in the top right is unthemed:

CleanShot 2024-11-15 at 19 41 39

Close icons in modals like this log out one are unthemed:

CleanShot 2024-11-15 at 19 41 58

isabelroses
isabelroses previously approved these changes Nov 17, 2024
sgoudham
sgoudham previously approved these changes Nov 17, 2024
@comfysage comfysage dismissed stale reviews from sgoudham and isabelroses via cfb99a9 November 17, 2024 22:13
@uncenter uncenter merged commit 12139c6 into catppuccin:main Nov 17, 2024
3 checks passed
@comfysage comfysage deleted the feat/pronouns.cc/init branch November 17, 2024 22:14
@NeonGamerBot-QK
Copy link
Member

Thank you finishing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants