Merge pull request #76 from causy-dev/unify-triple-format

refactor(independence_tests): standardize triples, all lists now
causy-dev · Jan 29, 2025 · c5e68b3 · c5e68b3
2 parents b3f27e3 + b2282e1
commit c5e68b3
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 8 deletions.
diff --git a/causy/causal_discovery/constraint/algorithms/pc.py b/causy/causal_discovery/constraint/algorithms/pc.py
@@ -91,9 +91,7 @@
 PCClassic = graph_model_factory(
     Algorithm(
         pipeline_steps=[
-            CalculatePearsonCorrelations(
-                display_name="Calculate Pearson Correlations"
-            ),
+            CalculatePearsonCorrelations(display_name="Calculate Pearson Correlations"),
             CorrelationCoefficientTest(
                 threshold=VariableReference(name="threshold"),
                 display_name="Correlation Coefficient Test",

diff --git a/causy/causal_discovery/constraint/independence_tests/common.py b/causy/causal_discovery/constraint/independence_tests/common.py
@@ -256,7 +256,9 @@ def process(
                     "triple": [
                         graph.nodes[nodes[0]],
                         graph.nodes[nodes[1]],
-                        nodes_set - {graph.nodes[nodes[0]], graph.nodes[nodes[1]]},
+                        list(
+                            nodes_set - {graph.nodes[nodes[0]], graph.nodes[nodes[1]]}
+                        ),
                     ],
                 },
             )
@@ -269,7 +271,9 @@ def process(
                     "triple": [
                         graph.nodes[nodes[0]],
                         graph.nodes[nodes[1]],
-                        nodes_set - {graph.nodes[nodes[0]], graph.nodes[nodes[1]]},
+                        list(
+                            nodes_set - {graph.nodes[nodes[0]], graph.nodes[nodes[1]]}
+                        ),
                     ],
                 },
             )
@@ -349,7 +353,9 @@ def process(
                     "triple": [
                         graph.nodes[nodes[0]],
                         graph.nodes[nodes[1]],
-                        nodes_set - {graph.nodes[nodes[0]], graph.nodes[nodes[1]]},
+                        list(
+                            nodes_set - {graph.nodes[nodes[0]], graph.nodes[nodes[1]]}
+                        ),
                     ],
                 },
             )
@@ -362,7 +368,9 @@ def process(
                     "triple": [
                         graph.nodes[nodes[0]],
                         graph.nodes[nodes[1]],
-                        nodes_set - {graph.nodes[nodes[0]], graph.nodes[nodes[1]]},
+                        list(
+                            nodes_set - {graph.nodes[nodes[0]], graph.nodes[nodes[1]]}
+                        ),
                     ]
                 },
             )
diff --git a/tests/test_pc_e2e.py b/tests/test_pc_e2e.py
@@ -3,7 +3,8 @@
     PC,
     PC_ORIENTATION_RULES,
     PC_GRAPH_UI_EXTENSION,
-    PC_DEFAULT_THRESHOLD, PCClassic,
+    PC_DEFAULT_THRESHOLD,
+    PCClassic,
 )
 from causy.causal_effect_estimation.multivariate_regression import (
     ComputeDirectEffectsInDAGsMultivariateRegression,