Added ShuffleInplace implementation to Network's Worker source #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves this issue. The problem was that the Worker did not have the shuffleInplace function implemented.
To replicate the error before this commit try to train a network asyncronously with
shuffle: true
in config, like the following:Both
npm run test
andnpm run build
worked after this alteration locally, but I don't know how to make a failing/suceeding test with this stack, if someone does then feel free to replace this pull request entirely. Tested locally with the built/dist/synaptic.js
file on a project and validated it fixes the issue too.