Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ShuffleInplace implementation to Network's Worker source #346

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added ShuffleInplace implementation to Network's Worker source #346

wants to merge 2 commits into from

Conversation

GuilhermeRossato
Copy link

This PR solves this issue. The problem was that the Worker did not have the shuffleInplace function implemented.

To replicate the error before this commit try to train a network asyncronously with shuffle: true in config, like the following:

    trainer.trainAsync(trainingSets[channelId], {
        iterations: 2500,
        log: 250,
        rate: 0.01,
        error: 0.01,
        shuffle: true,
        cost: Trainer.cost.CROSS_ENTROPY
    })

Both npm run test and npm run build worked after this alteration locally, but I don't know how to make a failing/suceeding test with this stack, if someone does then feel free to replace this pull request entirely. Tested locally with the built /dist/synaptic.js file on a project and validated it fixes the issue too.

To solve this [issue](#238). The problem was that the Worker did not have the shuffleInplace function implemented. (Tested the code locally in a browser)
It didn't change since the project started so I guess it's safe to say it is stable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant