Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing release 0.1.2 #42

Merged
merged 68 commits into from
Feb 7, 2018
Merged

Preparing release 0.1.2 #42

merged 68 commits into from
Feb 7, 2018

Conversation

artivis
Copy link
Collaborator

@artivis artivis commented Jan 18, 2018

There has been quite a few changes on the develop branch since the last release.
It would be nice to get them out there before integrating the heavier #36 & #37.

Related #38.

Main changes :

  • Enable multi config files per package
  • Unit testing
  • Python support
  • Yaml generator

vincentrou and others added 30 commits July 3, 2017 16:00
@vincentrou
Remove useless character
52a8387
@poggenhans
param handler now generates python parameter files too
0f83e8e
@olesalscheider @poggenhans
Fix initialisation order in parameter class template
f34f612
@poggenhans
Set default values on parameter server if no value is set
9dd15bd
@poggenhans
Include python usage in documentation
d331bb6
@poggenhans
Add min/max check for map and vector to be consistent with C++
84ff1a4
@cbandera
Handler is now throwing an exception upon failure.
87c050a 
Before, it was calling std::exit(EXIT_FAILURE) but it was causing problems during testing.
@cbandera
Moved common functions to utilities.hpp. Fixes #11
8a5bab0
@cbandera
Updated README to include release information. Closes #17.
5bbd0d5
@cbandera
Added LICENSE file. Closes #25
bbd4de2
@cbandera
Added first set of tests
32e2450
@cbandera
Added initial travis config
233b48a
@cbandera
Added matrix job and removed C++14 check
1d02859
@cbandera
Updated README contribution guide
158b22e
@cbandera
Changed build flag to display develop branch
4bacbbf
@cbandera
Merge pull request #26 from cbandera/feature/add_continous_integration
dffb6a3 
Feature/add continous integration
@poggenhans
Merge remote-tracking branch 'cbandera/develop' into python_support
97b647b
@poggenhans
Add python unittests
30eb393
@poggenhans
Throw more informative exception if parameters without default value …
f0be113 
…are unset
@poggenhans
Name tests properly, add cmake dependency
2cf0e8b
@poggenhans
Merge remote-tracking branch 'cbandera/develop' into set_defaults_on_…
b504810 
…param_server
@poggenhans
Add unittests
86796e2
@poggenhans
Remove duplicate test
83d3523
@cbandera
Updated the documentation
07d52f8
@cbandera
Merge pull request #22 from poggenhans/set_defaults_on_param_server
d8c8cbc 
Set default values on parameter server if no value is set
@cbandera
Merge branch 'develop' into python_support
3204fdb
@cbandera
Merge branch 'develop' into fix_init_order
b20f66e
@cbandera
Merge branch 'develop' into patch-1
3eb9f78
@cbandera
Merge pull request #19 from vincentrou/patch-1
5fcce2c 
Remove useless character
@cbandera
Merged branch develop into fix_init_order
d3878c5
cbandera and others added 20 commits September 12, 2017 21:24
@cbandera
Removed debugging leftover
cba741b
@cbandera
Moved common function to util header
66c004e
@cbandera
Added documentation to functions
6f68db6
@cbandera
Added functionality for setting parameters on server.
094ce23 
This should resolve #31
@cbandera
Fix for failing tests
4e969e8
@cbandera
Simplified utility functions
3f0b727
@cbandera
ClangFormat files
79c715f
@cbandera
Reformatted python files
16e88a9
@cbandera
Merge pull request #32 from cbandera/feature/toParamServer
b54b7d9 
Closes #31
@cbandera
Merge remote-tracking branch 'origin/develop' into feature/generate_yaml
c8cd086
@cbandera
Added documentation for generator script
0f0af52
@cbandera
Uncomment lines without default, to force user to set them
9134a50
@cbandera
Bugfixes
ee68c64
@cbandera
Renamed script again
3fa3f47
@cbandera
Merge pull request #33 from cbandera/feature/generate_yaml
64a23fa 
YamlGenerator closes #30
add dynamic_reconfigure test
0bd890a
std::endl -> \n
01f2c5e
@artivis
Merge pull request #39 from cbandera/test/dynamic_reconf
096d4b5 
Add test dynamic_reconfigure
update maintainer
a31e7be
@artivis
Merge pull request #40 from cbandera/update_maintainer
c650412 
Update maintainer
@artivis artivis requested a review from cbandera January 18, 2018 12:38
@artivis artivis self-assigned this Jan 18, 2018
@artivis artivis mentioned this pull request Jan 18, 2018
Closed
Jeremie Deray and others added 2 commits February 4, 2018 14:09
fix #34
8a69587
@artivis
Merge pull request #43 from cbandera/fix/compile
68bbd06 
fix #34. Append local path at the beginning of PYTHON_PATH
@artivis artivis added this to the 0.1.2 milestone Feb 4, 2018
@artivis
Copy link
Collaborator Author

artivis commented Feb 5, 2018

@cbandera This PR has been pending for quite some time now. This is all rather well tested code and with #34 being fixed I plan on merging/releasing this Wednesday.

cbandera
cbandera approved these changes Feb 6, 2018
View reviewed changes
Copy link
Owner

@cbandera cbandera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so Long.
PR Looks good. I Just found that the readme is still taking about Release 0.1.1

@artivis
Copy link
Collaborator Author

artivis commented Feb 7, 2018

Thanks for reviewing 👍
I'll update the readme once the release done.

@artivis artivis merged commit 6372038 into master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbandera cbandera cbandera approved these changes

Assignees

@artivis artivis

Labels
None yet
Projects
None yet
Milestone
0.1.2
Development

Successfully merging this pull request may close these issues.
6 participants
@artivis @cbandera @GDwag @vincentrou @poggenhans @olesalscheider