Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Issue: 1086 - Image editor #1462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arjunanand23
Copy link

This PR fixes the issue where the image editing toolbar is below the picture, which necessitates use of scrollbar for smaller monitors.

@martinbedouret
Copy link
Collaborator

Thanks @arjunanand23 ! Great job
@RodriSanchez1 Could you please give a review?

@RodriSanchez1
Copy link
Collaborator

hi @arjunanand23 ! Sorry for the late response. Good job! I think we can also redefine the height on setImageSize() like :

line 37
---------------------------------------------
 const setImageSize = () => {
      if (window.innerWidth < 576) {
        return { width: 248, height: 182 };
      } else {
        return { width: 492, height: 300 };
      }
    };

To avoid unnecesary scroll on the DialogContent component. Let me know what you think!

@RodriSanchez1
Copy link
Collaborator

close #1086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants