Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Translations from the Original Repo #137

Closed
wants to merge 1 commit into from

Conversation

JakobDev
Copy link
Contributor

There are a few PR's with Translations in the Original Repo. I think, it's time to merge it.

Credits:
dan200/ComputerCraft#365 by @manu-03
dan200/ComputerCraft#527 by @absolument
dan200/ComputerCraft#538 by @nothjarnan

@SquidDev SquidDev added the enhancement An extension of a feature or a new feature. label Mar 13, 2019
@SquidDev
Copy link
Member

SquidDev commented Mar 13, 2019

Thanks for putting this together - I kept meaning to do something about these PRs, but then forgot. The langugage files have changed a little bit, so probably worth revisiting these first.

I've got in touch with @nothjarnan and @daelvn (author of dan200/ComputerCraft#488) to see if they want to review them. If any other French, Spanish, Swedish (or other languages!) want to drop in their opinions, feel free!

@SquidDev
Copy link
Member

Thanks for putting these together :).

I've cherry picked the French and Spanish commits in manually, and northjarnan has PRed Swedish in. Doing it this way means they're picked up as contributors, and so appear on the credits & stats :).

@SquidDev SquidDev closed this Mar 19, 2019
@JakobDev JakobDev deleted the newlang branch March 19, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An extension of a feature or a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants