-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing type
column back to data dict and README feature table
#327
Add missing type
column back to data dict and README feature table
#327
Conversation
type
column to data dict and README feature tabletype
column back to data dict and README feature table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for doing the chores (so to speak) @jeancochrane. Should we also include a ccao
version bump in here? Doesn't seem like it affects the outputs, but couldn't hurt.
Ooh, good catch @dfsnow! Done in 5075cab, and mirrored to the condo model in ccao-data/model-condo-avm@2aa1667 (I had upgraded the package over there but neglected to snapshot the lockfile). |
@@ -1712,15 +1712,15 @@ | |||
}, | |||
"terra": { | |||
"Package": "terra", | |||
"Version": "1.7-83", | |||
"Version": "1.8-10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this only just started failing now (example) but it seems like raster
is no longer installing properly. Updating its main dependency terra
to the latest version seems to fix the problem.
…327) * Add missing `type` column to data dict and README feature table * Update CCAO package version * Try updating terra dependency to resolve raster install problems
I noticed while working on the condo model data dict that I had made a small typo in #315 that accidentally wiped the
Type
column from the data dict and theFeatures Used
table in the README. This PR fixes that typo and rebuilds the data dict and README to match.