Skip to content

Conversation

@jaschutte
Copy link
Contributor

@jaschutte jaschutte commented Jul 28, 2025

Rather than use a predefined local version of GHC, use the same version the clash compiler uses. This makes it so the flake doesn't have to get independently updated and can just follow whatever clash-compiler has.

This change has been made to following the decision to pin clash-compiler to a minor version of GHC. Changing minor versions for each project depending on clash-compiler will be tedious, so this will make it automatically follow the same version of clash-compiler.

Marked as draft until clash-lang/clash-compiler#2984 is merged.

TODO:

  • Update flake.lock (depends on PR)

@jaschutte
Copy link
Contributor Author

@martijnbastiaan CI seems to be failing over signatures, any clue as to why/how that works?

@martijnbastiaan
Copy link
Collaborator

No clue... If I'm to hazard a guess it's a temporary failure. Try again tomorrow? 🫠

@jaschutte jaschutte marked this pull request as ready for review July 28, 2025 15:47
@jaschutte jaschutte force-pushed the master branch 2 times, most recently from 2336df9 to e2e7d07 Compare July 29, 2025 09:41
@jaschutte
Copy link
Contributor Author

The issue had to do with haskell-actions having dropped support for Cabal 3.6 some time ago (I have no clue for how long). The solution is to simply update Cabal to a newer version.

The upstream bug report: haskell-actions/setup#122

matrix:
os: [ubuntu-latest]
cabal: ["3.6"]
cabal: ["3.16"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to just drop cabal entirely? I trust the action to figure out the right Cabal version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar enough with how github CI works to know what "dropping" exactly means hehe. I can set it to latest which would just follow the latest supported version of the Cabal. I think that would achieve the same goal.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that should work :)

Rather than use a predefined local version of GHC, use the same version
the clash compiler uses. This makes it so the flake doesn't have to get
independently updated and can just follow whatever clash-compiler has.

It also updates the cabal version of CI to a supported release. Cabal
3.6 supported was dropped ??? ago and it broke CI.
@martijnbastiaan martijnbastiaan merged commit 68484f9 into cchalmers:master Jul 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants