Working on DHCPv4 options

ccie18643 · Sep 9, 2024 · 6bf931d · 6bf931d
1 parent 8d1b908
commit 6bf931d
Show file tree

Hide file tree

Showing 2 changed files with 210 additions and 54 deletions.
diff --git a/pytcp/protocols/dhcp4/options/dhcp4_option__message_type.py b/pytcp/protocols/dhcp4/options/dhcp4_option__message_type.py
@@ -54,7 +54,7 @@
 # +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
 
 
-DHCP4__OPTION__MESSAGE_TYPE__LEN = 4
+DHCP4__OPTION__MESSAGE_TYPE__LEN = 3
 DHCP4__OPTION__MESSAGE_TYPE__STRUCT = "! BB B"
 
 
@@ -124,7 +124,7 @@ def _validate_integrity(_bytes: bytes, /) -> None:
         if (value := _bytes[1]) > len(_bytes):
             raise Dhcp4IntegrityError(
                 "The DHCPv4 Message Type option length must be less than or equal "
-                "to the length of provided bytes ({len(_bytes)}). Got: {value!r}"
+                f"to the length of provided bytes ({len(_bytes)}). Got: {value!r}"
             )
 
     @override
@@ -146,4 +146,4 @@ def from_bytes(_bytes: bytes, /) -> Dhcp4OptionMessageType:
 
         Dhcp4OptionMessageType._validate_integrity(_bytes)
 
-        return Dhcp4OptionMessageType(Dhcp4MessageType.from_int(_bytes[3]))
+        return Dhcp4OptionMessageType(Dhcp4MessageType.from_int(_bytes[2]))