fix overzealous label state mapper

ccims · Sep 17, 2024 · 069c118 · 069c118
1 parent 6eed297
commit 069c118
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/sync/src/main/kotlin/gropius/sync/AbstractSync.kt b/sync/src/main/kotlin/gropius/sync/AbstractSync.kt
@@ -423,16 +423,20 @@ abstract class AbstractSync(
         mappedStates: List<IssueState>
     ) {
         val labelStateMap = this.labelStateMap(imsProject)
-        timelineItems.remove(timelineItem)
-        val newStateChange = StateChangedEvent(
-            timelineItem.createdAt, timelineItem.lastModifiedAt
-        )
-        newStateChange.oldState().value = lastState
-        newStateChange.newState().value = mappedStates.firstOrNull() ?: lastState//TODO("Restore State out of nothing")
-        newStateChange.createdBy().value = timelineItem.createdBy().value
-        newStateChange.lastModifiedBy().value = timelineItem.lastModifiedBy().value
-        timelineItems.add(newStateChange)
-        issue.timelineItems().add(newStateChange)
+        val mappedState = lookupState(labelStateMap[timelineItem.removedLabel().value?.name])
+        if ((mappedState != null) && !mappedStates.contains(mappedState)) {
+            timelineItems.remove(timelineItem)
+            val newStateChange = StateChangedEvent(
+                timelineItem.createdAt, timelineItem.lastModifiedAt
+            )
+            newStateChange.oldState().value = lastState
+            newStateChange.newState().value =
+                mappedStates.firstOrNull() ?: lastState//TODO("Restore State out of nothing")
+            newStateChange.createdBy().value = timelineItem.createdBy().value
+            newStateChange.lastModifiedBy().value = timelineItem.lastModifiedBy().value
+            timelineItems.add(newStateChange)
+            issue.timelineItems().add(newStateChange)
+        }
     }
 
     /**