Merge pull request #57 from ccims/bugfix/negative_hashes

fix bug in case of evil negative hashes
ccims · Jul 11, 2023 · aa12a87 · aa12a87
2 parents 26fa6db + 61c7d0c
commit aa12a87
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/core/src/main/kotlin/gropius/service/user/AvatarGenerationService.kt b/core/src/main/kotlin/gropius/service/user/AvatarGenerationService.kt
@@ -3,6 +3,8 @@ package gropius.service.user
 
 import org.springframework.stereotype.Service
 import java.util.*
+import kotlin.math.abs
+import kotlin.math.max
 import kotlin.math.pow
 
 private const val SIZE = 36
@@ -27,7 +29,7 @@ class AvatarGenerationService {
      * @return The avatar as Base64 encoded SVG data url
      */
     fun generateAvatar(id: String): String {
-        val numFromName = id.hashCode()
+        val numFromName = max(abs(id.hashCode()), 0)
         val range = colors.size
         val preTranslateX = getUnit(numFromName, 10, 1)
         val wrapperTranslateX = if (preTranslateX < 5) preTranslateX + SIZE / 9.0 else preTranslateX.toDouble()