support permission checks with disabled auth

ccims · Jul 24, 2023 · be5b043 · be5b043
1 parent f69806e
commit be5b043
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/api-common/src/main/kotlin/gropius/graphql/GraphQLConfiguration.kt b/api-common/src/main/kotlin/gropius/graphql/GraphQLConfiguration.kt
@@ -14,6 +14,7 @@ import com.fasterxml.jackson.databind.ObjectMapper
 import graphql.Scalars
 import graphql.scalars.regex.RegexScalar
 import graphql.schema.*
+import gropius.authorization.checkPermission
 import gropius.authorization.gropiusAuthorizationContext
 import gropius.model.common.PERMISSION_FIELD_BEAN
 import gropius.model.template.TEMPLATED_FIELDS_FILTER_BEAN
@@ -185,11 +186,10 @@ class GraphQLConfiguration {
                 node: org.neo4j.cypherdsl.core.Node,
                 nodeDefinition: NodeDefinition
             ): Expression {
-                val context = dfe.gropiusAuthorizationContext
-                return if (context.checkPermission) {
+                return if (dfe.checkPermission) {
                     val conditionGenerator = nodeDefinitionCollection.generateAuthorizationCondition(
                         nodeDefinition,
-                        Permission(arguments["permission"] as String, context)
+                        Permission(arguments["permission"] as String, dfe.gropiusAuthorizationContext)
                     )
                     val condition = conditionGenerator.generateCondition(node)
                     condition

diff --git a/core/src/main/kotlin/gropius/authorization/GropiusAuthorizationContext.kt b/core/src/main/kotlin/gropius/authorization/GropiusAuthorizationContext.kt
@@ -31,4 +31,15 @@ val DataFetchingEnvironment.gropiusAuthorizationContext: GropiusAuthorizationCon
         throw IllegalArgumentException("No GropiusAuthorizationContext available")
     }
     return tempAuthorizationContext
+}
+
+/**
+ * Gets checkPermission of a possibly set [GropiusAuthorizationContext] and evaluates to false otherwise
+ */
+val DataFetchingEnvironment.checkPermission: Boolean get() {
+    return if (this.authorizationContext is GropiusAuthorizationContext) {
+        this.gropiusAuthorizationContext.checkPermission
+    } else {
+        false
+    }
 }