Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assignments outgoing #149

Merged
merged 3 commits into from
Oct 18, 2024
Merged

assignments outgoing #149

merged 3 commits into from
Oct 18, 2024

Conversation

chriku
Copy link
Contributor

@chriku chriku commented Oct 16, 2024

No description provided.

@chriku chriku marked this pull request as ready for review October 16, 2024 17:01
@chriku chriku requested a review from nk-coding October 16, 2024 17:01
@@ -882,10 +906,87 @@ abstract class AbstractSync(
* @param timeline Timeline of the issue
* @param imsProject IMS project to sync
* @param issueInfo Issue to sync
* @param label Label to sync
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

* Sync Outgoing Assignments
* @param timeline Timeline of the issue
* @param imsProject IMS project to sync
* @param issueInfo Issue to sync
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing dokka

assignment: Assignment,
virtualIDs: Map<TimelineItem, String>
) {
var labelIsSynced = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong name

sync/src/main/kotlin/gropius/sync/AbstractSync.kt Outdated Show resolved Hide resolved
*/
private suspend fun syncOutgoingAssignments(
timeline: List<TimelineItem>, imsProject: IMSProject, issueInfo: IssueConversionInformation
) {
val labelStateMap = this.labelStateMap(imsProject)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong name?

@chriku chriku merged commit 877516a into main Oct 18, 2024
1 check passed
@chriku chriku deleted the feature/assignments branch October 18, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants