Feature/login frontend integration #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spethso
reviewed
Nov 18, 2023
| ### To use it for oauth, set a redirect url | ||
| ### The clientId of the created/found auth client will be printed to the console on startup | ||
| #GROPIUS_DEFAULT_AUTH_CLIENT_NAME=initial-client | ||
| #GROPIUS_DEFAULT_AUTH_CLIENT_ID=01234567-89ab-cdef-fedc-ba9876543210 |
There was a problem hiding this comment.
Should such an ID be public visible in the repository?
There was a problem hiding this comment.
this one is just for development
it's just a random UUID, imho it does not really matter
of course you should never ever deploy it in production using dev mode
| @@ -156,7 +156,8 @@ export class AuthClientController { | |||
| } else { | |||
| newClient.isValid = true; | |||
| } | |||
| if (input.requiresSecret != undefined) { | |||
| newClient.clientSecrets = [] | |||
There was a problem hiding this comment.
Is this list nonempty or null before, or why do you assign an empty list? Especially, since it is not filled in the remaining method.
There was a problem hiding this comment.
afaik it's undefined before
| @@ -71,7 +71,7 @@ export abstract class StrategyUsingPassport extends Strategy { | |||
| passportStrategy, | |||
| { | |||
| session: false, | |||
| state: jwtService.sign(authStateData), | |||
| state: jwtService.sign(authStateData), // TODO: check if an expiration and/or an additional random value are needed | |||
There was a problem hiding this comment.
I assume the TODO comment is on intention. Perhaps also create an issue for it so we do not miss the TODO?
spethso
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probably more work to do, but I want to make a realease...