Next #2
Merged
Next #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nk-coding
commented
Jul 27, 2024
nk-coding
commented
- remove username password flow
- add PKCE (required)
- use public/private key JWT signing/verification
- add GitHub/Jira cloud token strategy
- host frontend directly by login service
- add schema for strategy instance configuration
- add endpoint to read (admin) censored strategy instance configuration
- move to /auth root endpoint
- display error messages for failed login/register events
- make redirect URLs required
spethso
requested changes
Jul 29, 2024
| } | ||
| if ( | ||
| state.activeLogin.nextExpectedRefreshTokenNumber != | ||
| ActiveLogin.LOGGED_IN_BUT_TOKEN_NOT_YET_RETRIVED + (state.secondToken ? 2 : 0) |
There was a problem hiding this comment.
What do the numbers mean? Would it make sense to change them to something clearer?
There was a problem hiding this comment.
added a comment with b950100
spethso
approved these changes
Jul 29, 2024
spethso
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.