-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next #2
Conversation
nk-coding
commented
Jul 27, 2024
- remove username password flow
- add PKCE (required)
- use public/private key JWT signing/verification
- add GitHub/Jira cloud token strategy
- host frontend directly by login service
- add schema for strategy instance configuration
- add endpoint to read (admin) censored strategy instance configuration
- move to /auth root endpoint
- display error messages for failed login/register events
- make redirect URLs required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double check the public and private key comment
} | ||
if ( | ||
state.activeLogin.nextExpectedRefreshTokenNumber != | ||
ActiveLogin.LOGGED_IN_BUT_TOKEN_NOT_YET_RETRIVED + (state.secondToken ? 2 : 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do the numbers mean? Would it make sense to change them to something clearer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a comment with b950100