-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
leptonica v1.83.0 #5
Comments
How strange The fields still seem to be there https://github.com/DanBloomberg/leptonica/blob/master/src/pix_internal.h#L234 What operating system are you using and how did you install leptonica? I might be able to replicate your setup. |
I found in release notes https://github.com/DanBloomberg/leptonica/blob/master/version-notes.html#L116 I install from source code |
rename .so lib DanBloomberg/leptonica@29a33a3 |
split interface DanBloomberg/leptonica@e8b670d |
tesseract has prepared tesseract-ocr/tesseract#3851 |
I've managed to replicate the issue |
I've had to disable doc tests because some of the syntax in the autogenerated comments confuses it. It looks like access to the PIX struct is now private, so we need to use getters. I started looking at this because of this issue in leptonica-plumbing ccouzens/leptonica-plumbing#5 --- To test using my dev version of leptonica I need to use this command ```bash LD_LIBRARY_PATH=../../DanBloomberg/leptonica/local/lib PKG_CONFIG_PATH=../../DanBloomberg/leptonica/local/lib/pkgconfig cargo test --lib ``` My checkout of leptonica was built with ```bash sudo dnf builddep leptonica-devel ./autogen.sh ./configure --prefix /configure "--prefix=$(pwd)/local" make make install ```
I've had to disable doc tests because some of the syntax in the autogenerated comments confuses it. It looks like access to the PIX struct is now private, so we need to use getters. I started looking at this because of this issue in leptonica-plumbing ccouzens/leptonica-plumbing#5 --- To test using my dev version of leptonica I need to use this command ```bash LD_LIBRARY_PATH=../../DanBloomberg/leptonica/local/lib PKG_CONFIG_PATH=../../DanBloomberg/leptonica/local/lib/pkgconfig cargo test --lib ``` My checkout of leptonica was built with ```bash sudo dnf builddep leptonica-devel ./autogen.sh ./configure --prefix /configure "--prefix=$(pwd)/local" make make install ```
#5 ```bash LD_LIBRARY_PATH="$(pwd)/../../DanBloomberg/leptonica/local/lib" PKG_CONFIG_PATH="$(pwd)/../../DanBloomberg/leptonica/local/lib/pkgconfig" cargo test ```
Just to keep you updated: I'm working on this. It requires refactoring and a new interface as some things we could do previously are no longer possible. I'm mostly there with this repository, but I want to get branches of tesseract-plumbing, LepTess and tesseract-rs using it too to ensure the new interface is good. I also want to improve the test coverage. |
Hello! I am also facing the issue. What can be a possible temp solution to this? Like downgrading leptonica or... |
Hi @PureSci , Sorry to hear you're also having the issue. Yes, in the mean time can you downgrade leptonica. I've been building it manually so I can use 1.83.0 to work with the new ABI. You'll need to go back to 1.82.0 or earlier. These are my notes on building it manually.
Assuming you used a |
ccouzens/leptonica-plumbing#5 It doesn't currently work, but I expect it can be refactored. ```bash LD_LIBRARY_PATH="$(pwd)/../../DanBloomberg/leptonica/local/lib" PKG_CONFIG_PATH="$(pwd)/../../DanBloomberg/leptonica/local/lib/pkgconfig" bash -c 'cargo test --release && valgrind --leak-check=yes --error-exitcode=1 --leak-check=full --show-leak-kinds=all "$(find target/*/deps/ -executable -name 'leptess-*')"' ```
I've raised a PR here #6. Please feel free to review and comment. |
How to downgrade into 1.82.0 if I installed on Windows 10? Install command on windows: |
@dbernatt I don't know. I tried to use When Googling I found some information about checking out an older version of As a work around you might be able to wait until the fix is merged.
|
@dbernatt You can use the vcpkg.json manifest for overriding leptonica version or other packages (as a workaround for now). {
"dependencies": [
"leptonica",
"tesseract",
"vcpkg-cmake-config",
"vcpkg-cmake-get-vars",
"vcpkg-cmake",
],
"overrides": [
{
"name": "leptonica",
"version": "1.82.0"
}
]
} Then just |
@eniolajayi yes. I've released leptonica-plumbing 1.0.0 which fixes this. But I suspect you're not using this directly. I've been waiting until some upstream projects are fixed before making an announcement. Tesseract-plumbing uses this updated version in 0.8.0. LepTess has an open pr on it. If there's no comments soon I'll merge and release. houqp/leptess#54 |
ccouzens/leptonica-plumbing#5 It doesn't currently work, but I expect it can be refactored. ```bash LD_LIBRARY_PATH="$(pwd)/../../DanBloomberg/leptonica/local/lib" PKG_CONFIG_PATH="$(pwd)/../../DanBloomberg/leptonica/local/lib/pkgconfig" bash -c 'cargo test --release && valgrind --leak-check=yes --error-exitcode=1 --leak-check=full --show-leak-kinds=all "$(find target/*/deps/ -executable -name 'leptess-*')"' ```
It has support for leptonica-1.83.0 ccouzens/leptonica-plumbing#5
It has support for leptonica-1.83.0 ccouzens/leptonica-plumbing#5
Hey all, Everything is merged and released. Or the upstream projects Then everything should just work with leptonica-1.83.0. Let me know if otherwise. |
@ccouzens it's fixed! Thanks |
It has support for leptonica-1.83.0 ccouzens/leptonica-plumbing#5
Hello.
It does not work on new leptonica version v1.83.0
I tried to compile my project.
I got an error
The text was updated successfully, but these errors were encountered: