Leptonica 1.83.0 #54
Merged
Leptonica 1.83.0 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccouzens/leptonica-plumbing#5 It doesn't currently work, but I expect it can be refactored. ```bash LD_LIBRARY_PATH="$(pwd)/../../DanBloomberg/leptonica/local/lib" PKG_CONFIG_PATH="$(pwd)/../../DanBloomberg/leptonica/local/lib/pkgconfig" bash -c 'cargo test --release && valgrind --leak-check=yes --error-exitcode=1 --leak-check=full --show-leak-kinds=all "$(find target/*/deps/ -executable -name 'leptess-*')"' ```
Seeing as it will be a new release. It is technically a breaking change in parts, because the exposed leptonica-plumbing library has a new interface. And because `set_rectangle` has become `set_rectangle_from_box` , and some return types have changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make changes to support leptonica 1.83.0
ccouzens/leptonica-plumbing#5
Basically leptonica made the fields within its structs private. Which means we can only get go them via leptonica's methods.
In the case of pixa and boxa, it required bigger changes as we could no longer get to their items directly. When going through leptonica's methods, we no longer merely borrow the memory, but get a reference counted copy. This requires us to handle it differently (eg dropping it afterwards).