Temporarily remove masking geometry warnings #672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #671. In some cases this has started giving (apparently harmless) spam output. We are disabling temporarily while a workshop is running.
ndevenish
force-pushed
the
no_geom_warn
branch
from
f46f7b2 to
5efbf87
Compare
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Nov 24, 2023
Bugfixes -------- - Importing the (deprecated and removed) ``dxtbx.datablock`` module failed to display warning properly. Misc ---- - `cctbx#672 <https://github.com/cctbx/dxtbx/issues/672>`_
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
=======================================
Coverage 42.62% 42.62%
=======================================
Files 182 182
Lines 15924 15924
Branches 3056 3056
=======================================
Hits 6788 6788
Misses 8510 8510
Partials 626 626 |
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Nov 27, 2023
Bugfixes -------- - Importing the (deprecated and removed) ``dxtbx.datablock`` module failed to display warning properly. Misc ---- - `cctbx#672 <https://github.com/cctbx/dxtbx/issues/672>`_
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Dec 4, 2023
Bugfixes -------- - Importing the (deprecated and removed) ``dxtbx.datablock`` module failed to display warning properly. Misc ---- - `cctbx#672 <https://github.com/cctbx/dxtbx/issues/672>`_
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Dec 11, 2023
Bugfixes -------- - Importing the (deprecated and removed) ``dxtbx.datablock`` module failed to display warning properly. Misc ---- - `cctbx#672 <https://github.com/cctbx/dxtbx/issues/672>`_
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Dec 18, 2023
Bugfixes -------- - Importing the (deprecated and removed) ``dxtbx.datablock`` module failed to display warning properly. Misc ---- - `cctbx#672 <https://github.com/cctbx/dxtbx/issues/672>`_
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Dec 25, 2023
Bugfixes -------- - Importing the (deprecated and removed) ``dxtbx.datablock`` module failed to display warning properly. Misc ---- - `cctbx#672 <https://github.com/cctbx/dxtbx/issues/672>`_
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Jan 1, 2024
Bugfixes -------- - Importing the (deprecated and removed) ``dxtbx.datablock`` module failed to display warning properly. Misc ---- - `cctbx#672 <https://github.com/cctbx/dxtbx/issues/672>`_
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Jan 8, 2024
Bugfixes -------- - Importing the (deprecated and removed) ``dxtbx.datablock`` module failed to display warning properly. Misc ---- - `cctbx#672 <https://github.com/cctbx/dxtbx/issues/672>`_
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Jan 15, 2024
Bugfixes -------- - Importing the (deprecated and removed) ``dxtbx.datablock`` module failed to display warning properly. Misc ---- - `cctbx#672 <https://github.com/cctbx/dxtbx/issues/672>`_
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Jan 22, 2024
Bugfixes -------- - Importing the (deprecated and removed) ``dxtbx.datablock`` module failed to display warning properly. Misc ---- - `cctbx#672 <https://github.com/cctbx/dxtbx/issues/672>`_
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Jan 29, 2024
Bugfixes -------- - Importing the (deprecated and removed) ``dxtbx.datablock`` module failed to display warning properly. Misc ---- - `cctbx#672 <https://github.com/cctbx/dxtbx/issues/672>`_
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Feb 5, 2024
Bugfixes -------- - Importing the (deprecated and removed) ``dxtbx.datablock`` module failed to display warning properly. Misc ---- - `cctbx#672 <https://github.com/cctbx/dxtbx/issues/672>`_
DiamondLightSource-build-server
pushed a commit
to dials/dxtbx
that referenced
this pull request
Feb 7, 2024
Bugfixes -------- - Importing the (deprecated and removed) ``dxtbx.datablock`` module failed to display warning properly. Misc ---- - `cctbx#672 <https://github.com/cctbx/dxtbx/issues/672>`_
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Feb 12, 2024
Bugfixes -------- - Importing the (deprecated and removed) ``dxtbx.datablock`` module failed to display warning properly. Misc ---- - `cctbx#672 <https://github.com/cctbx/dxtbx/issues/672>`_
DiamondLightSource-build-server
added a commit
to dials/dxtbx
that referenced
this pull request
Feb 19, 2024
Bugfixes -------- - Importing the (deprecated and removed) ``dxtbx.datablock`` module failed to display warning properly. Misc ---- - `cctbx#672 <https://github.com/cctbx/dxtbx/issues/672>`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #671. In some cases this has started giving (apparently harmless) spam output. We are disabling temporarily while a workshop is running.
This PR is intended to be backported but we may not need to merge to main.