Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IQM devices #329

Merged
merged 24 commits into from
Jun 13, 2024
Merged

Add IQM devices #329

merged 24 commits into from
Jun 13, 2024

Conversation

flowerthrower
Copy link
Collaborator

Added configuration for IQM:

  • Adonis (5Qubits)
  • Apollo (20Qubits)

@flowerthrower flowerthrower linked an issue May 6, 2024 that may be closed by this pull request
Add IQM devices ✨ #326
Closed
@flowerthrower flowerthrower force-pushed the 326-add-iqm-devices branch from c30971f to 7c1eafa Compare May 6, 2024 10:56
@codecov Codecov
Copy link

codecov bot commented May 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.2%. Comparing base (9145701) to head (d29e2eb).
Report is 52 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##            main    #329     +/-   ##
=======================================
+ Coverage   92.9%   93.2%   +0.2%     
=======================================
  Files         47      48      +1     
  Lines       2422    2478     +56     
=======================================
+ Hits        2252    2311     +59     
+ Misses       170     167      -3
Flag Coverage Δ
python 93.2% <100.0%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flowerthrower flowerthrower marked this pull request as ready for review May 13, 2024 15:42
nquetschlich
nquetschlich requested changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@nquetschlich nquetschlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only major comment is regarding the native gate set. Depending on your answer to that we can discuss the pytket handling.

src/mqt/bench/calibration_files/iqm_apollo_calibration.json Show resolved Hide resolved
src/mqt/bench/calibration_files/iqm_adonis_calibration.json Show resolved Hide resolved
src/mqt/bench/tket_helper.py Outdated Show resolved Hide resolved
tests/devices/test_iqm_device_support.py Show resolved Hide resolved
nquetschlich
nquetschlich approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@nquetschlich nquetschlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again for the effort to adjust all tests. Highly appreciate it!

@flowerthrower flowerthrower enabled auto-merge June 13, 2024 11:25
@flowerthrower flowerthrower merged commit 37a3eae into main Jun 13, 2024
20 checks passed
@flowerthrower flowerthrower deleted the 326-add-iqm-devices branch June 13, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burgholzer burgholzer burgholzer left review comments

@nquetschlich nquetschlich nquetschlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
MQT Applications
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add IQM devices ✨
3 participants
@flowerthrower @burgholzer @nquetschlich