Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Add documentation for ZX-calculus package. #817

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

Conversation

pehamTom
Copy link
Member

@pehamTom pehamTom commented Jan 27, 2025

Description

This PR introduces documentation for the C++ ZX-calculus library.

Fixes #813

This change addresses concerns about missing documentation that came up in the revision openjournals/joss-reviews#7478 .

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.3%. Comparing base (68ea5fa) to head (c11c95d).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #817   +/-   ##
=====================================
  Coverage   92.3%   92.3%           
=====================================
  Files        127     127           
  Lines      13509   13509           
  Branches    2080    2080           
=====================================
+ Hits       12476   12477    +1     
+ Misses      1033    1032    -1     
Flag Coverage Δ
cpp 92.0% <100.0%> (+<0.1%) ⬆️
python 99.7% <ø> (ø)
Files with missing lines Coverage Δ
include/mqt-core/ir/operations/Expression.hpp 92.7% <ø> (ø)
include/mqt-core/zx/Rational.hpp 96.2% <ø> (ø)
include/mqt-core/zx/Simplify.hpp 100.0% <ø> (ø)
include/mqt-core/zx/Utils.hpp 100.0% <ø> (ø)
include/mqt-core/zx/ZXDefinitions.hpp 92.0% <ø> (ø)
include/mqt-core/zx/ZXDiagram.hpp 95.7% <ø> (ø)
src/zx/Simplify.cpp 97.1% <100.0%> (ø)
src/zx/ZXDiagram.cpp 91.9% <ø> (ø)

... and 1 file with indirect coverage changes

@burgholzer burgholzer added documentation Improvements or additions to documentation ZX Anything related to the ZX package c++ Anything related to C++ code labels Jan 27, 2025
@burgholzer burgholzer added this to the ZX Package Improvements milestone Jan 27, 2025
@burgholzer burgholzer changed the title Add documentation for ZX-calculus package. 📝 Add documentation for ZX-calculus package. Jan 27, 2025
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look phenomenal ✨ many thanks for taking the time to add these docstrings!
I just browsed through them and added a couple of inline comments where I noticed that something might be slightly off. Hope these help.

Looking forward to seeing this in the online documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code documentation Improvements or additions to documentation ZX Anything related to the ZX package
Projects
Status: In Progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

📝 Add documentation for ZX package
2 participants