[CDAP-21096] Split Appfabric into stateless service and stateful processor #15773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsethi09
force-pushed
the
feature/CDAP-21096_split_appfabric_service_processor
branch
7 times, most recently
from
6874823 to
75ec19d
Compare
vsethi09
requested review from
tivv,
chtyim,
masoud-io,
sahusanket and
itsankit-google
vsethi09
changed the title
vsethi09
force-pushed
the
feature/CDAP-21096_split_appfabric_service_processor
branch
from
75ec19d to
b3e3e17
Compare
Comment on lines
102
to
103
| CredentialProviderService credentialProviderService, | ||
| NamespaceCredentialProviderService namespaceCredentialProviderService, |
There was a problem hiding this comment.
why do we need CredentialProviderService in processor?
There was a problem hiding this comment.
How will it work in this case if the processor service does not host any handlers but GcpWorkloadIdentityHttpHandler runs in AppfabricService?
There was a problem hiding this comment.
Not needed. Removed.
| @@ -0,0 +1,216 @@ | |||
| /* | |||
| * Copyright © 2014-2020 Cask Data, Inc. | |||
vsethi09
force-pushed
the
feature/CDAP-21096_split_appfabric_service_processor
branch
from
b3e3e17 to
f88bc89
Compare
vsethi09
force-pushed
the
feature/CDAP-21096_split_appfabric_service_processor
branch
from
f88bc89 to
ce8bda2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Make appfabric service stateless by splitting it into appfabric service to server HTTP requests and appfabric processor to run subscriber services and process message.
Change Description
AppFabricProcessorServiceMainfor appfabric processor.AppFabricProcessorServicewhich is used byAppFabricProcessorServiceMain.AppFabricServerand moved them toAppFabricProcessorService.AppFabricServerandAppFabricProcessorServicedoes not have any HTTP handlers.Verification
AppFabricProcessorServiceTestto test Start and Stop (similar toAppFabricServerTest).AppFabricProcessorServiceMainas it does not host and HTTP handlers and runs only subscriber services.