[CDAP-21096] Remove in-memory launching queue from RunRecordMonitorService #15800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsethi09
force-pushed
the
feature/CDAP-21096_fix_RunRecordMonitorService_queue_cache
branch
5 times, most recently
from
dc068c3 to
0ea30c6
Compare
vsethi09
changed the title
vsethi09
force-pushed
the
feature/CDAP-21096_fix_RunRecordMonitorService_queue_cache
branch
from
0ea30c6 to
abcd4c5
Compare
tivv
reviewed
Jan 15, 2025
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/services/FlowControlMonitorService.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/services/FlowControlMonitorService.java
Outdated
Show resolved
Hide resolved
...c/src/main/java/io/cdap/cdap/internal/app/services/ProgramNotificationSubscriberService.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java
Outdated
Show resolved
Hide resolved
vsethi09
force-pushed
the
feature/CDAP-21096_fix_RunRecordMonitorService_queue_cache
branch
2 times, most recently
from
343101b to
db8a3ab
Compare
vsethi09
force-pushed
the
feature/CDAP-21096_fix_RunRecordMonitorService_queue_cache
branch
from
db8a3ab to
66da732
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/services/FlowControlService.java
Fixed
Show fixed
Hide fixed
vsethi09
force-pushed
the
feature/CDAP-21096_fix_RunRecordMonitorService_queue_cache
branch
3 times, most recently
from
ea09155 to
d9e4c13
Compare
tivv
reviewed
Jan 21, 2025
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/services/FlowControlService.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/services/FlowControlService.java
Outdated
Show resolved
Hide resolved
...c/src/main/java/io/cdap/cdap/internal/app/services/ProgramNotificationSubscriberService.java
Outdated
Show resolved
Hide resolved
...c/src/main/java/io/cdap/cdap/internal/app/services/ProgramNotificationSubscriberService.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java
Outdated
Show resolved
Hide resolved
vsethi09
force-pushed
the
feature/CDAP-21096_fix_RunRecordMonitorService_queue_cache
branch
from
d9e4c13 to
31c5b1c
Compare
tivv
approved these changes
Jan 22, 2025
...c/src/main/java/io/cdap/cdap/internal/app/services/ProgramNotificationSubscriberService.java
Show resolved
Hide resolved
vsethi09
force-pushed
the
feature/CDAP-21096_fix_RunRecordMonitorService_queue_cache
branch
from
31c5b1c to
0e1ba0b
Compare
vsethi09
force-pushed
the
feature/CDAP-21096_fix_RunRecordMonitorService_queue_cache
branch
from
0e1ba0b to
03216d0
Compare
|
vsethi09
deleted the
feature/CDAP-21096_fix_RunRecordMonitorService_queue_cache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Multiple instances of
RunRecordMonitoringServicecannot run as distributed services as the in-memory cache of the launching queue will result in inconsistencies.Removed the in-memory launching queue from the RunRecordMonitoringService and used
AppMetadataStoreAPIs.For more context, see: #15773 (comment).
Note:
RunRecordMonitoringServiceis renamed asFlowControlMonitoringService.Testing