Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lib): simplify structure, separate packages #8

Merged
merged 6 commits into from
Jan 12, 2024
Merged

Conversation

cdcabrera
Copy link
Owner

What's included

  • docs(dotenv): add public path webpack tip
  • fix(wpConfigs): avoid webpack merge on open path list
  • refactor(lib): simplify structure, separate packages
  • fix(wpConfigs): devServer, config watchFiles paths
  • fix(dotenv): apply default contextPath
  • test(fixtures): removeFixture, clean up

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

...

Example

...

Updates issue/story

ongoing

@cdcabrera cdcabrera added bug Something isn't working enhancement New feature or request build labels Jan 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

Merging #8 (3d26154) into main (6d966d1) will decrease coverage by 1.11%.
The diff coverage is 81.48%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   84.54%   83.43%   -1.11%     
==========================================
  Files           7        7              
  Lines         317      332      +15     
  Branches      104      108       +4     
==========================================
+ Hits          268      277       +9     
- Misses         43       49       +6     
  Partials        6        6              
Files Coverage Δ
src/wpConfigs.js 78.08% <80.00%> (-0.05%) ⬇️
src/dotenv.js 85.71% <82.35%> (-3.02%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d966d1...3d26154. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants