Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): packages, provide a require resolve #9

Merged
merged 1 commit into from
Jan 13, 2024
Merged

feat(lib): packages, provide a require resolve #9

merged 1 commit into from
Jan 13, 2024

Conversation

cdcabrera
Copy link
Owner

@cdcabrera cdcabrera commented Jan 13, 2024

What's included

  • feat(lib): packages, provide a require resolve

Notes

  • packages lib linter
  • expose a require.resolve for packages
    • allows for scenarios where webpack requires something like
       rules: [
         {
           test: /\.(sa|sc)ss$/i,
           use: [MiniCssExtractPlugin.loader, cssLoaderResolve, sassLoaderResolve]
         }
       ]
    

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Example

...

Updates issue/story

ongoing

@cdcabrera cdcabrera added the enhancement New feature or request label Jan 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024

Codecov Report

Merging #9 (0085188) into main (e7e3dc6) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   83.43%   83.43%           
=======================================
  Files           7        7           
  Lines         332      332           
  Branches      108      108           
=======================================
  Hits          277      277           
  Misses         49       49           
  Partials        6        6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e3dc6...0085188. Read the comment docs.

@cdcabrera cdcabrera merged commit 380c00c into main Jan 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants