Uncap urllib3 #328
Closed
Uncap urllib3 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue with urllib3 >= 2 was already fixed by [1]. [1] urllib3/urllib3@2459900
|
I might be confused by a different problem we had in the past... Let me check the failing job ... |
|
Ugh ok so the current problem is different and we have to make wsgi-intercept compatible with urllib3 2 ... |
|
Yeah, the situation with wsgi-intercept is big mess, and I'm struggling to figure it out. There is a pull request cdent/wsgi-intercept#76 that fixes it, but it is super fragile and just has the sense of not being the actually correct solution. If you're interested in looking at that and helping me either make it better or decide that it is okay, please feel free. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with urllib3 >= 2 was already fixed by [1].
[1] urllib3/urllib3@2459900