Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format source code events same as core #52

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

afrittoli
Copy link
Contributor

Reformat the source code version control stage page to match what
done for the core stage. No spec changes.

Part of #13

Signed-off-by: Andrea Frittoli [email protected]

Reformat the source code version control stage page to match what
done for the core stage. No spec changes.

Part of cdevents#13

Signed-off-by: Andrea Frittoli <[email protected]>
Copy link
Contributor

@e-backmark-ericsson e-backmark-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typos


A Source Code Repository modified some of its attributes, like location, or owner.

- Event Type: __`dev.cdevents.repository.created`__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Event Type: __`dev.cdevents.repository.created`__
- Event Type: __`dev.cdevents.repository.modified`__

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!


### `repository deleted`

- Event Type: __`dev.cdevents.repository.created`__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Event Type: __`dev.cdevents.repository.created`__
- Event Type: __`dev.cdevents.repository.deleted`__

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

Signed-off-by: Andrea Frittoli <[email protected]>
@afrittoli afrittoli merged commit f990094 into cdevents:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants