Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IPinfo.io as a source for timezone information through IP Geolocation. #114

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

abdullahdevrel
Copy link
Contributor

Hi,

I am the DevRel of IPinfo, and I have added IPinfo.io as a source for timezone information. The API response is fairly standard, so I don't think there would be any issues. The timezone information is returned in the IANA Time Zone Database format.

IPinfo API request

curl https://ipinfo.io/2.43.176.103/json

API response

{
    "ip": "2.43.176.103",
    "hostname": "mob-2-43-176-103.net.vodafone.it",
    "city": "Palermo",
    "region": "Sicily",
    "country": "IT",
    "loc": "38.1166,13.3636",
    "org": "AS30722 Vodafone Italia S.p.A.",
    "postal": "90100",
    "timezone": "Europe/Rome", <==========
    "readme": "https://ipinfo.io/missingauth"
}

Also, it is highly unlikely that our API will get timed out or throw any rate-related issues. Without the token, we support up to 1,000 requests per day.

Let me know if there are any issues. We would be very happy if the PR gets merged. Thanks!

@cdown
Copy link
Owner

cdown commented Jan 3, 2024

Hi Abdullah, thanks for the PR! Everything looks good.

Only one question:

Without the token, we support up to 1,000 requests per day.

Keyed per IP, right?

Thanks!

@abdullahdevrel
Copy link
Contributor Author

@cdown, Yes, this is based on per IP. In standard OS setups or timezone settings, users rarely (if ever) hit rate limits.

To be honest, I have only seen people hit rate limits when using a TOR IP address. We do not block TOR IPs, but usually, they just blast our endpoint, which is why the average TOR IP might get rate-limited.

But our API is perfect for all other IP addresses and the kind of operation that tzupdate is performing. Users of tzupdate will probably never encounter a rate limit through our API. Additionally, our IP geolocation data is one of the best in the industry.

@cdown
Copy link
Owner

cdown commented Jan 3, 2024

Great, thanks! This will go out with next release. Thanks for adding it!

@cdown cdown merged commit 8747c26 into cdown:master Jan 3, 2024
3 checks passed
@abdullahdevrel
Copy link
Contributor Author

Thank you very much. Really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants