Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: upgrade upload/download-artifact GitHub actions #123

Merged

Conversation

neutrinoceros
Copy link
Contributor

Hi, version 4 of upload-artifact and download-artifact were recently released.
Staying on old version is not viable long term because GitHub will sooner or later drop support for the old versions of node that these depend on.
Since migration to v4 is not as straightfoward as bumping the version number, I'm helping all astropy-related packages byt manually performing the necessary changes.

(in this specific case it is actually trivial, I'm just doing them all at once so no reason to skip this repo)

@ManonMarchand
Copy link
Member

CI Failure seems unrelated, it's the same than in #113 that I'll reopen (@fxpineau this bug only appears with external contributors)

Thanks for the help!

@ManonMarchand ManonMarchand merged commit 2787cc8 into cds-astro:master Jan 8, 2024
2 of 14 checks passed
@neutrinoceros neutrinoceros deleted the mnt/upload-artifacts-v4 branch January 8, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants