Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with JSON card data not rendered in the preview pane #122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kolkheang
Copy link
Collaborator

This PR corrects issue #121.

Code Mirror CSS and global CSS need this specific configuration to work properly.
Applying the original logic with this PR

@kolkheang
Copy link
Collaborator Author

@dennispatterson & @jmandel
Please review

@dennispatterson
Copy link
Collaborator

dennispatterson commented Oct 10, 2019

Thanks, @kolkheang! This gets the code showing up for editing, but don't think the CSS is quite right yet.

Original header:
Screen Shot 2019-10-10 at 10 02 28 AM

With these changes:
Screen Shot 2019-10-10 at 10 02 35 AM

Also, the code in the editor is missing brackets and colons (they're being rendered in white):
Screen Shot 2019-10-10 at 10 03 03 AM

@kolkheang
Copy link
Collaborator Author

Thanks for the feedback, @dennispatterson. Let me try to revert back to the old version of codemirror.

@kolkheang
Copy link
Collaborator Author

@barabo I don't have priv to add you as another reviewer. But, if you have some time, I wouldn't mind if you could also take a look at the style issues.

@kolkheang
Copy link
Collaborator Author

I track down the css issue to this https://github.com/cds-hooks/sandbox/blob/master/src/components/CardDemo/card-demo.css#L53 line which makes brackets in the code appear white. I'll adjust that so that everything is visible.

I will take a look at the buttons' color issue next.

@dennispatterson
Copy link
Collaborator

Thanks, @kolkheang! That seems to fix the brackets/text. Any idea what's going on with the header?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants