-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vue starter app #21
Conversation
There is currently a dependency issue (security vulnerability) with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of review - I have a few files left that I will continue with tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple comments/questions.
Do we plan to replace the lorem ipsum in the app content with other content?
Updates since last review:
Did not do:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small thing on the report a bug page. Would you also be able to update the gcds package to the latest version?
import TextArea from '@/components/forms/TextArea.vue' | ||
import Button from '@/components/forms/Button.vue' | ||
import DateModified from '@/components/DateModified.vue' | ||
import ErrorSummary from '@/components/forms/ErrorSummary.vue' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ErrorSummary.vue
file seems to be missing from components/forms
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think we could do the content revision and French content in a new PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small changes :)
All request changes met and code has been updated
starter-apps/vue/vue-template/src/components/HeaderBreadcrumbs.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's ship it!
Summary | Résumé
Adds a starter app for usage in Vue 3.
This starter app contains the following: