feat: fable test app homepage #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daine
requested changes
Sep 16, 2024
fable-test-app/package.json
Outdated
Comment on lines
14
to
15
| "@cdssnc/gcds-components": "^0.26.0", | ||
| "@cdssnc/gcds-components-react": "^0.26.0", |
There was a problem hiding this comment.
Could use another version bump 😜
| isCurrentHoliday? : boolean; | ||
| nextHoliday: { | ||
| date: string; | ||
| nameEn: string; | ||
| } | null; | ||
| federal?: boolean; | ||
| observedIn?: Provinces[]; |
There was a problem hiding this comment.
I like this one better for clarity, what do you think?
Suggested change
| observedIn?: Provinces[]; | |
| provincesObservedIn?: Provinces[]; |
| @@ -23,6 +29,27 @@ const NextHoliday: React.FC<NextHolidayProps> = ({ | |||
| return Math.floor((holidayDate.getTime() - today.getTime()) / (1000 * 3600 * 24)); | |||
| }; | |||
|
|
|||
| // Get long version of date | |||
| const nextHolidayDate = (dateString: string) => { | |||
There was a problem hiding this comment.
I see potential for this to be generalized, especially seeing the function call is nextHolidayDate(holidayDate) when it only returns formatting. Can we change it?
Suggested change
| const nextHolidayDate = (dateString: string) => { | |
| const formatDate = (dateString: string) => { |
fable-test-app/src/pages/Home.tsx
Outdated
| data.holidays.map((holiday: holidayObject) => { | ||
| if (holiday.federal === 1) { | ||
| const holidayDate = new Date (holiday.date).getTime(); | ||
| if (holidayDate > currentDate && !fedAssigned) { |
There was a problem hiding this comment.
Small suggestion to do the boolean check first so it doesn't have to do the second check if it's already been assigned
Suggested change
| if (holidayDate > currentDate && !fedAssigned) { | |
| if (!fedAssigned && holidayDate > currentDate) { |
fable-test-app/src/pages/Home.tsx
Outdated
| let nationwideAssigned = false; | ||
| data.holidays.map((holiday: holidayObject) => { | ||
| const holidayDate = new Date (holiday.date).getTime(); | ||
| if (holidayDate > currentDate && !nationwideAssigned) { |
| }; | ||
|
|
||
| // Create formatted list of <abbr> elements for provinces | ||
| const formatObservedIn = () => { |
There was a problem hiding this comment.
Suggested change
| const formatObservedIn = () => { | |
| const getObservedInProvinces = () => { |
or something similar; format* typically means you pass it something it'll change but this one just simply returns a block of html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Create homepage for the fable test app (holidays app) based on figma prototype.