This repository has been archived by the owner on May 1, 2023. It is now read-only.
feat: add A11yReport model #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj2
reviewed
Aug 24, 2021
api/models/TemplateScan.py
Outdated
| @@ -42,5 +42,5 @@ class TemplateScan(Base): | |||
|
|
|||
| @validates("data") | |||
| def validate_data(self, _key, value): | |||
| assert value != "" | |||
| assert value is not None | |||
There was a problem hiding this comment.
I think that just becomes an empty json string, which is not deal either. I will add both tests
api/tests/models/test_A11yReport.py
Outdated
| session.commit() | ||
|
|
||
|
|
||
| def test_a11y_report_empty_productfails(scan_fixture, session): |
There was a problem hiding this comment.
Similar version of these tests by product="" instead of just missing?
There was a problem hiding this comment.
Yes those get caught:
@validates("product")
def validate_product(self, _key, value):
> assert value != ""
E AssertionError
dj2
approved these changes
Aug 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
A11yReportmodel as defined in #9. It also adds better checks for JSONB fields in other models.