Skip to content
This repository has been archived by the owner on May 1, 2023. It is now read-only.

chore: refactored to organize routes and client #106

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Conversation

mohdnr
Copy link
Contributor

@mohdnr mohdnr commented Sep 2, 2021

Refactored the api so that components reside in their own route. This is needed to allow unique routes so that we don't clobber existing routes when using similar paths.

Also added a dev flag for the root_path so that we have consistency between local test and what's deployed to AWS. this can be removed once we migrate to scan-websites.alpha.canada.ca

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Plan for scanners/owasp-zap

✅   Terraform Format: success
✅   Terraform Plan: success

Plan: 0 to add, 1 to change, 0 to destroy
Show plan
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_ecs_cluster.scanning_tools will be updated in-place
  ~ resource "aws_ecs_cluster" "scanning_tools" {
        id                 = "arn:aws:ecs:ca-central-1:507252742351:cluster/scanning-tools"
        name               = "scanning-tools"
        tags               = {}
        # (3 unchanged attributes hidden)

      + setting {
          + name  = "containerInsights"
          + value = "enabled"
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Releasing state lock. This may take a few moments...

@mohdnr mohdnr marked this pull request as ready for review September 2, 2021 18:16
Copy link
Contributor

@maxneuvians maxneuvians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for including bandit!

@mohdnr mohdnr merged commit 6d2310a into main Sep 2, 2021
@mohdnr mohdnr deleted the fix/api_routing branch September 2, 2021 19:50
@mohdnr mohdnr linked an issue Sep 7, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate router class
2 participants