This repository has been archived by the owner on May 1, 2023. It is now read-only.
feat: user model #74
Merged
feat: user model #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj2
reviewed
Aug 13, 2021
| sa.Column("email_address", sa.String(length=255), nullable=False, unique=True), | ||
| sa.Column("password_hash", sa.String(length=255), nullable=False), | ||
| sa.Column( | ||
| "access_token", postgresql.UUID(as_uuid=True), nullable=False, unique=True |
There was a problem hiding this comment.
Probably want an index on this one.
There was a problem hiding this comment.
I thought unique columns don't need to be indexed because unique creates an implicit index? Happy to add one if this is not correct.
There was a problem hiding this comment.
I don't know alchemy, so maybe it does? We should verify that the index gets created though as we'll probably want to lookup by access_token a lot.
| sa.Column("id", postgresql.UUID(as_uuid=True), primary_key=True), | ||
| sa.Column("organisation_id", postgresql.UUID(as_uuid=True), nullable=False), | ||
| sa.Column("name", sa.String(), nullable=False), | ||
| sa.Column("email_address", sa.String(length=255), nullable=False, unique=True), |
There was a problem hiding this comment.
index? (I'm assuming login is email/password)
| session.rollback() | ||
|
|
||
|
|
||
| def test_user_empty_email_address_fails(organisation_fixture, session): |
There was a problem hiding this comment.
Add a test_user_duplicate_email_address test
There was a problem hiding this comment.
Good call! Fixed
dj2
approved these changes
Aug 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69. Adds a
usermodel based on the proposal in #9.