Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python assignment 1 #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

python assignment 1 #1

wants to merge 1 commit into from

Conversation

cecily-li
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Add python code in existing file assignment_1.ipynb to satisfy criteria for anagram tester for 2 test scenarios (capitalizations vs no capitalizations considered).

What did you learn from the changes you have made?

There are a handful of different ways to approach the problem and more code is not necessarily a good thing.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Yes, there were multiple other approaches to arrive at the same outcome. Some other approaches could have taken different methods to ignoring the capitalizations, sorting the word contents, etc.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Challenges were that I had methods I wanted to solve the problem in mind that I could not execute in python syntax. I overcame it by referring back to class content and consulting online resources like StackOverflow.

How were these changes tested?

I used the code I wrote to run the various test scenarios listed in the assignment file and compared the outcome to the expected outcome.

A reference to a related issue in your repository (if applicable)

N/A

Checklist

  • [x ] I can confirm that my changes are working as intended

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Your code executes without error and is well-commented. A suggestion would be to ensure you are giving the correct output as asked by the assignment ; ie asked for a Boolean not a string. Additionally, these function only takes two words, so coding for elements in a list is not necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants