Upgrade Rails to 7.0 #138
Merged
Upgrade Rails to 7.0 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santiagorodriguez96
force-pushed
the
sr--upgrade-to-rails-70
branch
3 times, most recently
from
5a65d1c to
1b7e135
Compare
| @@ -21,7 +21,7 @@ def create | |||
| def callback | |||
| webauthn_credential = relying_party.verify_registration( | |||
| params, | |||
| session["current_registration"]["challenge"], | |||
| session[:current_registration][:challenge], | |||
There was a problem hiding this comment.
@soartec-lab it turns out that it was needed to use symbols to access the session data instead of strings as it was in fact returning nil after upgrading to Rails 7.0 😅
There was a problem hiding this comment.
Thank you for let me know. My doubts were cleared. And I'm glad I was able to contribute👍
The command used to update was: ``` bin/rails update --conservative rails ```
Just copied the changes over from #132. Co-authored-by: Shodai Suzuki <[email protected]>
santiagorodriguez96
force-pushed
the
sr--upgrade-to-rails-70
branch
from
1b7e135 to
6f0c143
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgraded Rails to 7.0.8. Also had to remove
springas it was causing some errors (and we don't really need it) and accesssessiondata usingsymbolsinstead ofstringsas after the upgrade it the latter approach was not working. There are a couple of deprecation warnings that I'll tackle as part of a separate PR.