Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce standardize_variables() #18

Merged
merged 21 commits into from
Jul 21, 2021
Merged

introduce standardize_variables() #18

merged 21 commits into from
Jul 21, 2021

Conversation

cedricbatailler
Copy link
Owner

@cedricbatailler cedricbatailler commented Jun 29, 2021 •
edited
Loading

Introduce standardize_variables() which scales variables in data frame.

Usage:

ho_et_al %>%
  standardize_variables(sdo)

ho_et_al %>%
  standardize_variables(c(sdo, linkedfate))

Should make it easier to obtain standardized coefficients (#6)

TODO

  • write unit tests
  • check whether other part of the doc should be updated
  • update NEWS.md

@cedricbatailler cedricbatailler self-assigned this Jun 29, 2021
@cedricbatailler cedricbatailler removed the request for review from YoannJulliard July 2, 2021 12:14
@cedricbatailler cedricbatailler marked this pull request as ready for review July 2, 2021 12:31
@cedricbatailler cedricbatailler added the enhancement New feature or request label Jul 5, 2021
@cedricbatailler cedricbatailler changed the title introduce standrdize_variables() introduce standardize_variables() Jul 19, 2021
YoannJulliard
YoannJulliard approved these changes Jul 21, 2021
View reviewed changes
Copy link
Collaborator

@YoannJulliard YoannJulliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the function and reviewed the changed files, I only noticed a little typo and suggested a correction. Otherwise, it seems all good.

R/compute_indirect_effect_for.R Outdated Show resolved Hide resolved
@cedricbatailler @YoannJulliard
Typo
edced64 
Co-authored-by: YoannJulliard <[email protected]>
@cedricbatailler cedricbatailler merged commit b21a3a7 into main Jul 21, 2021
@cedricbatailler cedricbatailler deleted the feature-standardize-variables branch July 21, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoannJulliard YoannJulliard YoannJulliard approved these changes

Assignees

@cedricbatailler cedricbatailler

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cedricbatailler @YoannJulliard