Leverage WASM_BIGINT for 64-bit integers #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tims-bsquare
reviewed
Dec 6, 2023
| @@ -164,7 +164,7 @@ class FunctionTypeExtension extends TypeExtension<FunctionType, FunctionDecorati | |||
| return | |||
| } | |||
|
|
|||
| const internalType = thread.lua.lua_rawgeti(thread.address, LUA_REGISTRYINDEX, func) | |||
| const internalType = thread.lua.lua_rawgeti(thread.address, LUA_REGISTRYINDEX, BigInt(func)) | |||
There was a problem hiding this comment.
This conversion seems odd. Should luaL_ref now return bigint?
There was a problem hiding this comment.
It does seem a bit strange, but this matches the lua function definitions:
LUA_API int (lua_rawgeti) (lua_State *L, int idx, lua_Integer n);
// ...
LUALIB_API int (luaL_ref) (lua_State *L, int t);
tims-bsquare
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
WASM_BIGINTenables support for using thebiginttype in JS to pass 64-bit integers. This allows compiling lua with full 64-bit integer/float support. I ran this against my (fairly large) lua application and it seemed to resolve all the issues I was previously having with large numbers in lua.