Starting point #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d lots of comments and proper destruction
Update vk-bootstrap
Make SwapchainBuilder not need graphics queue index parameter.
CMAKE_CURRENT_SOURCE_DIR is not necessary in the dedicated target attribute functions of cmake. Cmake will suffix any path token with the current source path. find_program is a useful utility to pick up binaries. When SDL is installed the include path directives will not work - to mitigate this problem on linux system the find_library(sdl2) is used. It lacks the REQUIRED token - so users can still set a manually built a non-system SDL
CMake cleanup
Fix SDL_PATH in CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.