Upgrade GitHub Actions and PyPy 3.10 and Django 5.0 #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
changed the title
|
@auvipy Can you please approve the workflow runs so I can see if these tests pass? |
|
Could we get a status update on this? I want to upgrade to Django 5, but I can't because of the incompatibility with |
|
|
auvipy
reviewed
Dec 13, 2023
tox.ini
Outdated
| @@ -72,7 +74,7 @@ commands = | |||
| basepython = python3.9 | |||
| usedevelop = true | |||
| commands = | |||
| pip install -U https://github.com/celery/celery/zipball/master#egg=celery | |||
| pip install -U https://github.com/celery/kombu/zipball/master#egg=kombu | |||
| pip install --upgrade https://github.com/celery/celery/zipball/master#egg=celery | |||
There was a problem hiding this comment.
Suggested change
| pip install --upgrade https://github.com/celery/celery/zipball/master#egg=celery | |
| pip install --upgrade https://github.com/celery/celery/zipball/main#egg=celery |
cclauss
changed the title
cclauss
changed the title
Closed
auvipy
requested changes
Dec 19, 2023
cclauss
changed the title
|
https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#specifying-a-pypy-version Let's land with |
cclauss
changed the title
cclauss
added a commit
to cclauss/django-celery-beat
that referenced
this pull request
Dec 19, 2023
* Upgrade GitHub Actions and PyPy * Let's drop Django v5 on PyPy v3.10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading our project from Django v4.2 to v5.0 downgraded our versions of django-celery-beat and django-timezone-field!
Pipfile.lock:"django-celery-beat": { [ ... ] - "version": "==2.5.0" + "version": "==2.1.0" },%
python3.12 -m venv .venv%
source .venv/bin/activate%
pip install --upgrade pip%
pip install django==5.0 django-celery-beat==2.5.0--> Failure%
pip install django==5.0 django-celery-beat--> Success but withdjango-celery-beatdowngraded2.5.0-->v2.1.0anddjango-timezone-fielddowngraded fromv6.1.0-->v4.2.3Please release a new version to PyPI.