Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: interpret the ssl_check_hostname as a boolean #2229

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

d9pouces
Copy link

!close #2210

ssl_check_hostname is left as-is ("false"), and is evaluated to True when a Redis connection is created.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.49%. Comparing base (a0175b0) to head (d60f18f).

Files with missing lines Patch % Lines
kombu/utils/url.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2229      +/-   ##
==========================================
- Coverage   81.50%   81.49%   -0.02%     
==========================================
  Files          77       77              
  Lines        9524     9526       +2     
  Branches     1152     1153       +1     
==========================================
  Hits         7763     7763              
- Misses       1569     1570       +1     
- Partials      192      193       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssl_check_hostname parameter is not respected for Redis connections
1 participant