chore(lint): bump golang-ci lint to 1.60 (#3678)

celestiaorg · Aug 23, 2024 · 5ffa175 · 5ffa175
1 parent 87e2802
commit 5ffa175
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 12 deletions.
diff --git a/.github/workflows/go-ci.yml b/.github/workflows/go-ci.yml
@@ -44,7 +44,7 @@ jobs:
         uses: golangci/[email protected]
         with:
           args: --timeout 10m
-          version: v1.59
+          version: v1.60
           skip-cache: true
 
   lint-imports:

diff --git a/.golangci.yml b/.golangci.yml
@@ -13,7 +13,7 @@ linters:
     # - funlen
     # - gochecknoglobals
     # - gochecknoinits
-    - exportloopref
+    - copyloopvar
     - gocheckcompilerdirectives
     - goconst
     - gocritic
@@ -40,7 +40,6 @@ linters:
     - prealloc
     - protogetter
     # - scopelint - deprecated since v1.39. exportloopref will be used instead
-    - exportloopref
     - staticcheck
     - stylecheck
     - typecheck
@@ -68,6 +67,9 @@ issues:
   max-same-issues: 50
 
 linters-settings:
+  gosec:
+    excludes:
+      - G115 # integer overflow conversion
   dogsled:
     max-blank-identifiers: 3
   golint:

diff --git a/core/exchange.go b/core/exchange.go
@@ -104,7 +104,6 @@ func (ce *Exchange) getRangeByHeight(ctx context.Context, from, amount uint64) (
 	errGroup, ctx := errgroup.WithContext(ctx)
 	errGroup.SetLimit(concurrencyLimit)
 	for i := range headers {
-		i := i
 		errGroup.Go(func() error {
 			extHeader, err := ce.GetByHeight(ctx, from+uint64(i))
 			if err != nil {

diff --git a/nodebuilder/rpc/flags_test.go b/nodebuilder/rpc/flags_test.go
@@ -80,11 +80,11 @@ func TestParseFlags(t *testing.T) {
 
 			err := cmd.Flags().Set(addrFlag, test.addrFlag)
 			if err != nil {
-				t.Errorf(err.Error())
+				t.Errorf("error setting addrFlag: %s", err)
 			}
 			err = cmd.Flags().Set(portFlag, test.portFlag)
 			if err != nil {
-				t.Errorf(err.Error())
+				t.Errorf("error setting portFlag: %s", err)
 			}
 
 			ParseFlags(cmd, cfg)

diff --git a/share/eds/retriever_test.go b/share/eds/retriever_test.go
@@ -45,7 +45,6 @@ func TestRetriever_Retrieve(t *testing.T) {
 		{"128x128(max)", share.MaxSquareSize},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			// generate EDS
 			shares := sharetest.RandShares(t, tc.squareSize*tc.squareSize)

diff --git a/share/eds/utils.go b/share/eds/utils.go
@@ -129,8 +129,6 @@ func CollectSharesByNamespace(
 	errGroup, ctx := errgroup.WithContext(ctx)
 	shares = make([]share.NamespacedRow, len(rootCIDs))
 	for i, rootCID := range rootCIDs {
-		// shadow loop variables, to ensure correct values are captured
-		i, rootCID := i, rootCID
 		errGroup.Go(func() error {
 			row, proof, err := ipld.GetSharesByNamespace(ctx, bg, rootCID, namespace, len(root.RowRoots))
 			shares[i] = share.NamespacedRow{

diff --git a/share/getters/getter_test.go b/share/getters/getter_test.go
@@ -301,7 +301,6 @@ func BenchmarkIPLDGetterOverBusyCache(b *testing.B) {
 	g := sync.WaitGroup{}
 	g.Add(blocks)
 	for _, h := range headers {
-		h := h
 		go func() {
 			defer g.Done()
 			_, err := getter.GetEDS(ctx, h)

diff --git a/share/ipld/get_shares_test.go b/share/ipld/get_shares_test.go
@@ -70,8 +70,6 @@ func TestBlockRecovery(t *testing.T) {
 		{"missing all but one shares", allShares, true, "failed to solve data square", extendedShareCount - 1},
 	}
 	for _, tc := range testCases {
-		tc := tc
-
 		t.Run(tc.name, func(t *testing.T) {
 			squareSize := utils.SquareSize(len(tc.shares))