Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shwap): Shwap cascade and mock getters #3599

Merged
merged 1 commit into from
Jul 31, 2024
Merged

feat(shwap): Shwap cascade and mock getters #3599

merged 1 commit into from
Jul 31, 2024

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented Jul 25, 2024 •
edited by Wondertan
Loading

Update according to new shwap.Getter interface. Move to new pkg structure:

  • cascase
  • mock getters

Remove:

  • old store.Getter
  • old ipld.Getter

@walldiss walldiss added kind:feat Attached to feature PRs shwap labels Jul 25, 2024
@walldiss walldiss self-assigned this Jul 25, 2024
@walldiss walldiss force-pushed the shwap-cascade-and-mock-getters branch from 81c15ed to fc99b26 Compare July 31, 2024 11:15
@walldiss walldiss force-pushed the shwap-cascade-and-mock-getters branch from fc99b26 to 89169ed Compare July 31, 2024 11:18
@walldiss walldiss marked this pull request as ready for review July 31, 2024 11:18
Wondertan
Wondertan approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

@Wondertan Wondertan merged commit 42913ea into celestiaorg:shwap Jul 31, 2024
15 of 18 checks passed
@Wondertan Wondertan deleted the shwap-cascade-and-mock-getters branch July 31, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay Awaiting requested review from renaynay

@vgonkivs vgonkivs Awaiting requested review from vgonkivs

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd

@ramin ramin Awaiting requested review from ramin

@cristaloleg cristaloleg Awaiting requested review from cristaloleg

Assignees

@walldiss walldiss

Labels
kind:feat Attached to feature PRs shwap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@walldiss @Wondertan